Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @radix-ui/react-select to 2.0.0 #1688

Merged
merged 5 commits into from
Nov 12, 2023

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Oct 6, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 6, 2023

@harryzcy is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@shadcn
Copy link
Collaborator

shadcn commented Oct 18, 2023

Do you know where I can find the release notes for this version? I can't find it here: https://www.radix-ui.com/primitives/docs/overview/releases

Thank you

@shadcn shadcn added the postpone: more info or changes requested maintainers asked a question or needs more info label Oct 18, 2023
@harryzcy
Copy link
Contributor Author

It seems radix-ui/primitives#2174 is why it's breaking.

Originally posted by @benoitgrelard in radix-ui/primitives#2174 (comment)

Making this a major as this is potentially a breaking change for people who were relying on using an option with value="" instead of the placeholder.

@harryzcy
Copy link
Contributor Author

@shadcn Hi, is there any update to this?

@shadcn
Copy link
Collaborator

shadcn commented Nov 12, 2023

@harryzcy Thanks for the links. Looks good.

@shadcn shadcn added area: www automerge and removed postpone: more info or changes requested maintainers asked a question or needs more info labels Nov 12, 2023
@kodiakhq kodiakhq bot merged commit 1ae9ffc into shadcn-ui:main Nov 12, 2023
6 of 7 checks passed
Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 10:34am

@harryzcy harryzcy deleted the bump-radix-select branch November 12, 2023 11:12
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants